Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent unintended node movement after using Ctrl-drag to copy a node #11089

Merged
merged 2 commits into from
Sep 4, 2020
Merged

Prevent unintended node movement after using Ctrl-drag to copy a node #11089

merged 2 commits into from
Sep 4, 2020

Conversation

Dewb
Copy link
Contributor

@Dewb Dewb commented Sep 1, 2020 •
edited

Purpose

Fixes #10720.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • n/a User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • n/a Snapshot of UI changes, if any.
  • n/a Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • n/a This PR modifies some build requirements and the readme is updated

aparajit-pratap
aparajit-pratap approved these changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@aparajit-pratap aparajit-pratap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Dewb for fixing this!

@aparajit-pratap
Copy link
Contributor

@alfredo-pozo can we add a UI automation test to test ctrl-drag interaction on nodes?

@aparajit-pratap aparajit-pratap merged commit 661d0b4 into DynamoDS:master Sep 4, 2020
@alfredo-pozo
Copy link
Contributor

I think we can, can you help us to create the Jira task for that @aparajit-pratap @QilongTang ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aparajit-pratap aparajit-pratap aparajit-pratap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strange drag+ctrl copy node behavior
4 participants
@Dewb @aparajit-pratap @alfredo-pozo @mike-d-adsk